build: update control-plane submodule addressing infinite rebuilds #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should address the inifite rebuild issue when no code change is made. Dev UX should now improve as consecutive cargo builds should not rebuild. Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
requested review from
sinhaashish,
Abhinandan-Purkait,
niladrih and
abhilashshetty04
sinhaashish
approved these changes
Jan 22, 2024
tiagolobocastro
force-pushed
the
fix-rebuild
branch
2 times, most recently
from
3e718e7 to
731ebcd
Compare
Checks for a few common words and outputs the error if found. These commits bring no value when browsing the history and should be squashed onto the parent commit. Checks for duplicate commit subjects. Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
force-pushed
the
fix-rebuild
branch
from
731ebcd to
7edc769
Compare
niladrih
approved these changes
Jan 23, 2024
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address the inifite rebuild issue when no code change is made. Dev UX should now improve as consecutive cargo builds should not rebuild.
Description
Motivation and Context
Regression
How Has This Been Tested?
Types of changes
Checklist: